-
Notifications
You must be signed in to change notification settings - Fork 88
fix(transformers): fix fast UT errors of ShieldGemma2, AltClip, GroundingDino, UDOP, Jetmoe #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @wtomin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical data type incompatibility issue within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a TypeError
with masked_scatter
when using the bfloat16
data type by casting the tensors to float32
before the operation. The fix is correct and includes a helpful FIXME
comment explaining the workaround. However, the change is applied to mindone/transformers/models/gemma3/modeling_gemma3.py
, which is an auto-generated file. As my review comment points out, this change should be made in the source file src/transformers/models/gemma3/modular_gemma3.py
to prevent it from being overwritten.
inputs_embeds = ( | ||
inputs_embeds.float().masked_scatter(special_image_mask, image_features.float()).to(inputs_embeds.dtype) | ||
) # FIXME: ms 2.6.0 does not support masked_scatter under bf16. Problem was fixed in ms 2.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
Fixes # (issue)
Tensor.masked_scatter
operator has an error under BF16 data type:TyperError: For primitivce[MaskedScatter], the input argument[updates] must be a type of {Tensor[Bool], Tensor[Float16], Tensor[Float32], Tensor[Float64], Tensor[Int16], Tensor[Int32]...
Fixed this error by setting the
inputs_embeds
andimage_features
to float32 tensors.Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SamitHuang @vigo999