-
Notifications
You must be signed in to change notification settings - Fork 88
feat(transformers): add flava model #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @wcrzlh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the FLAVA model, a new multimodal model, into the library. The changes include the model implementation, associated image processors, and updates to auto-classes for registration. My review focuses on several critical bugs found in the model's output handling, potential logic errors in loss calculation, and maintainability improvements such as correcting type hints and avoiding wildcard imports. I've also noted a typo in a test directory name.
|
||
if itm_labels is not None: | ||
pos_pairs = itm_labels.ne(0) | ||
pos_mask = mint.where(pos_pairs.any(), pos_pairs, ms.tensor([True], dtype=pos_pairs.dtype)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential logic bug here. When pos_pairs.any()
is False
(i.e., there are no positive image-text pairs in the batch), pos_mask
becomes ms.tensor([True])
. When this mask is used to index a batch of embeddings, it will likely select only the first element of the batch. This means subsequent losses (like MMM and global contrastive) would be computed on a potentially negative sample, which is incorrect. A better approach would be to let pos_mask
be pos_pairs
directly. If all values are False
, the indexed tensors will be empty, and the losses should gracefully handle this (e.g., result in zero loss).
@@ -0,0 +1,480 @@ | |||
# coding=utf-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This pr is extracted from Mike's PR.
Adds # (feature)
✅ Flava Model
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx