-
Notifications
You must be signed in to change notification settings - Fork 88
[FEATURE] add Lxmert model #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the Lxmert model, a multi-modal transformer for language and vision, ported from Hugging Face's PyTorch implementation to MindSpore. The core model logic and auto-model registration are included. However, the review identified several critical issues stemming from the direct porting of PyTorch-specific code, which will lead to runtime errors. These include incorrect weight initialization and tensor manipulation syntax. Additionally, the accompanying tests are incomplete, covering only the base model and not the heads for pre-training or question answering. I have provided detailed comments and suggestions to address these issues, fix the bugs, and enhance the overall code quality and test coverage.
What does this PR do?
Fixes # (issue)
Adds # (feature)
Add Lxmert model
will encounter same error as huggingface/transformers#7266 (comment)
need to migrate demo to validate end-to-end accuracy: https://github.com/huggingface/transformers-research-projects/tree/main/lxmert
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx