Skip to content

Conversation

wcrzlh
Copy link
Contributor

@wcrzlh wcrzlh commented Aug 18, 2025

What does this PR do?

Fixes # (issue)

Adds # (feature)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@wcrzlh wcrzlh requested a review from vigo999 as a code owner August 18, 2025 04:11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @wcrzlh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant enhancements to the mindone.transformers library by refactoring and adding new functionalities for model state dictionary loading and key management, alongside comprehensive unit tests for both cache_utils and modeling_utils. The changes aim to make model loading more robust, flexible, and better handle various scenarios such as shared parameters and key renaming.

Highlights

  • Enhanced Model Loading Logic: Introduced new helper functions and methods in modeling_utils.py to refine how model state dictionaries are loaded, including handling of shared tensors and key remapping.
  • Improved Static Cache Initialization: Modified StaticCache in cache_utils.py to provide more flexible initialization by allowing batch_size or max_batch_size to be specified, enhancing its usability.
  • Comprehensive Unit Testing: Added new test files (test_cache_utils.py and test_modeling_utils.py) with extensive unit tests covering DynamicCache and StaticCache functionalities, various from_pretrained scenarios (including low_cpu_mem_usage and safetensors), and attention mask utilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces unit tests for cache_utils and modeling_utils, which is a great addition for ensuring code quality and correctness. The changes also include a significant and valuable refactoring of the model loading logic in modeling_utils.py, making it more robust and maintainable. The changes to cache_utils.py for backward compatibility are also well-implemented. I have one suggestion regarding a wildcard import to improve code clarity.

import transformers
from packaging import version

from .cache_utils import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using wildcard imports (from ... import *) is generally discouraged as it can pollute the namespace and make it unclear which names are being imported. This can lead to maintenance issues and potential name clashes. It's better to explicitly import the required names from cache_utils.

from .cache_utils import (
    Cache,
    DynamicCache,
    EncoderDecoderCache,
    HybridCache,
    MambaCache,
    OffloadedStaticCache,
    SlidingWindowCache,
    StaticCache,
)

@vigo999 vigo999 added the ut/st label Sep 29, 2025
@vigo999 vigo999 added this to mindone Sep 29, 2025
@vigo999 vigo999 moved this to In Progress in mindone Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants