-
Notifications
You must be signed in to change notification settings - Fork 88
feat(transformers): add ut for cache/modeling_utils #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @wcrzlh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant enhancements to the mindone.transformers
library by refactoring and adding new functionalities for model state dictionary loading and key management, alongside comprehensive unit tests for both cache_utils
and modeling_utils
. The changes aim to make model loading more robust, flexible, and better handle various scenarios such as shared parameters and key renaming.
Highlights
- Enhanced Model Loading Logic: Introduced new helper functions and methods in
modeling_utils.py
to refine how model state dictionaries are loaded, including handling of shared tensors and key remapping. - Improved Static Cache Initialization: Modified
StaticCache
incache_utils.py
to provide more flexible initialization by allowingbatch_size
ormax_batch_size
to be specified, enhancing its usability. - Comprehensive Unit Testing: Added new test files (
test_cache_utils.py
andtest_modeling_utils.py
) with extensive unit tests coveringDynamicCache
andStaticCache
functionalities, variousfrom_pretrained
scenarios (includinglow_cpu_mem_usage
andsafetensors
), and attention mask utilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces unit tests for cache_utils
and modeling_utils
, which is a great addition for ensuring code quality and correctness. The changes also include a significant and valuable refactoring of the model loading logic in modeling_utils.py
, making it more robust and maintainable. The changes to cache_utils.py
for backward compatibility are also well-implemented. I have one suggestion regarding a wildcard import to improve code clarity.
import transformers | ||
from packaging import version | ||
|
||
from .cache_utils import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using wildcard imports (from ... import *
) is generally discouraged as it can pollute the namespace and make it unclear which names are being imported. This can lead to maintenance issues and potential name clashes. It's better to explicitly import the required names from cache_utils
.
from .cache_utils import (
Cache,
DynamicCache,
EncoderDecoderCache,
HybridCache,
MambaCache,
OffloadedStaticCache,
SlidingWindowCache,
StaticCache,
)
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New
. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx