Add RecResizeNormImg in Rec Transform to manage padding and norm in resize, add yaml of crnn for server version [WIP] #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 85a3394.
zhtmike
reviewed
Jun 20, 2023
| return data | ||
|
|
||
|
|
||
| # TODO: remove infer_mode and character_dict_path if they are not necesary |
There was a problem hiding this comment.
那个character_dict_path 和 infer_mode 要不顺便清了，这两个argument很ambiguous而且容易忘记
There was a problem hiding this comment.
好，我看下
那个
character_dict_path和infer_mode要不顺便清了，这两个argument很ambiguous而且容易忘记
SamitHuang
reviewed
Jun 20, 2023
| imgH, imgW = image_shape | ||
| # todo: change to 0 and modified image shape | ||
| max_wh_ratio = imgW * 1.0 / imgH | ||
| h, w = img.shape[0], img.shape[1] | ||
| c = img.shape[2] | ||
| ratio = w * 1.0 / h | ||
|
|
||
| max_wh_ratio = min(max(max_wh_ratio, ratio), max_wh_ratio) |
There was a problem hiding this comment.
这一步是多余的。 等价于 max_wh_ratio=max_wh_ratio
There was a problem hiding this comment.
这一步是多余的。 等价于 max_wh_ratio=max_wh_ratio
嗯嗯fixed
zhtmike
approved these changes
Jun 26, 2023
SamitHuang
approved these changes
Jun 26, 2023
|
Please report the results for crnn server version and upload the checkpoint and mindir. |
SamitHuang
changed the title
因為server version model暫時只有一個，沒有單獨開一個section去描述，目前是把結果append在原來的表格後面，用num_classes予以區分。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
Develop landable version of CRNN.
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)