Skip to content

Conversation

@guzman-raphael
Copy link

Fix #38

@mindsers
Copy link
Owner

Does this PR passes unit tests?

@mindsers mindsers self-requested a review February 19, 2021 08:50
@mindsers mindsers added question Further information is requested severity: 2 (broken) type: bug Something isn't working labels Feb 19, 2021
@mindsers mindsers added type: enhancement New feature or request and removed severity: 2 (broken) type: bug Something isn't working labels Jul 31, 2021
@mindsers mindsers self-assigned this Jul 31, 2021
@mindsers
Copy link
Owner

@guzman-raphael Hey, I looked again at this PR and one thing we need to take care is the validation feature.

The Action validates the format of the changelog's entries base on Semantic Versioning, but allowing other versioning format might break the validation checks.
Either we should ensure if validations checks are still working when using other formats, or we should deactivate the validation checks when the Action detect it is not valid SemVer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preleases in Python do not parse appropriately

3 participants