Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Inference engines #59

Merged
merged 9 commits into from
Dec 25, 2023
Merged

[refactor] Inference engines #59

merged 9 commits into from
Dec 25, 2023

Conversation

paxcema
Copy link
Contributor

@paxcema paxcema commented Dec 21, 2023

Changelog:

  • Reorganized codebase into inference engines
  • Current approach is now the "rule based" engine
  • Define new class abstractions
  • Move existing engine from method to class
  • Figure out if the current fan out approach is general enough for other engines.
  • Clean up API entry points
  • Refactor so that there are approach-specific reqs
  • Organize poetry deps into core + per-engine

…s runs (is close to the ideal end state) and does not break existing code.
@paxcema paxcema requested a review from pedrofluxa December 21, 2023 12:03
@paxcema paxcema self-assigned this Dec 21, 2023
@paxcema paxcema marked this pull request as ready for review December 22, 2023 13:18
@pedrofluxa pedrofluxa marked this pull request as draft December 22, 2023 19:45
Copy link
Contributor

@pedrofluxa pedrofluxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tidy to me. I think this refactor is a great idea that will help maintain and extend our current type inference capabilities.

Approving PR.

@paxcema paxcema marked this pull request as ready for review December 25, 2023 09:42
@paxcema paxcema merged commit 667e581 into staging Dec 25, 2023
10 checks passed
@paxcema paxcema mentioned this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants