Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions to set up a dev environment #16

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

mrandri19
Copy link
Contributor

@mrandri19 mrandri19 commented Oct 20, 2022

The current documentation on how to setup a development environment is outdated, see https://mindsdb.github.io/type_infer/#setting-up-a-dev-environment.
pip install requirements.txt does not work anymore after switching to a poetry + pyproject.toml workflow.

The CI works because it has been updated to use pip install -e ., see https://github.com/mindsdb/type_infer/blob/staging/.github/workflows/python-package.yml#L29.

This PR updates the documentation to match what is done in CI.

@ZoranPandovski ZoranPandovski merged commit f3097ad into mindsdb:staging Oct 20, 2022
@mrandri19
Copy link
Contributor Author

mrandri19 commented Oct 20, 2022

Would it be possible to get an hacktoberfest-accepted label on this PR? It's related to #11 in some sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants