Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support combining queries: intersect, except #411

Merged
merged 25 commits into from
Nov 11, 2024
Merged

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Oct 30, 2024

Support parsing and planning of

query1 INTERSECT [ALL] query2
query1 EXCEPT [ALL] query2

Fix: https://linear.app/mindsdb/issue/BE-433/intersectexcept-support

Copy link

github-actions bot commented Oct 30, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sql
   __about__.py10100%1–10
   __init__.py1292283%43, 47, 93, 110, 134–153, 160–161, 178
mindsdb_sql/parser
   lexer.py165199%243
   logger.py19479%14, 17, 23, 26
   parser.py4603193%48, 53, 73, 77, 81, 87, 91–93, 121–128, 182, 199, 249, 253, 317, 346–347, 367, 378, 491, 526, 557, 567, 581, 662
   utils.py46491%73–79
mindsdb_sql/parser/ast
   base.py36781%13, 28, 31, 49–52
   create.py761087%7–8, 23, 28, 91–96
   drop.py52296%10, 13
   insert.py63494%39–41, 46
   show.py48198%18
   update.py53591%40–42, 75–76
mindsdb_sql/parser/ast/select
   case.py39295%20, 23
   constant.py36197%23
   data.py11282%15, 19
   identifier.py64789%43, 80–85
   native_query.py13192%25
   operation.py136497%56, 65, 170, 194
   parameter.py11191%10
   select.py97397%148–153
   star.py12283%8–9
mindsdb_sql/parser/dialects/mindsdb
   knowledge_base.py46198%79
   lexer.py2642192%345, 347, 349, 361, 363, 365, 371–389
   parser.py10442797%119, 123, 262, 287, 384, 570, 587, 611–612, 811, 865, 942, 1086, 1096, 1134–1135, 1164, 1175, 1257, 1320, 1359, 1395, 1879, 1887, 1940–1943
mindsdb_sql/parser/dialects/mysql
   lexer.py23674%16, 18, 20, 32, 34, 36
   parser.py6132496%131, 133, 226–227, 326, 356, 373, 423, 427, 501, 511, 549–550, 570, 581, 702, 730, 735–737, 741, 758, 907, 1051
   show_index.py171135%10–12, 15–23, 26–27
mindsdb_sql/planner
   plan_join.py3731795%145, 153, 187, 196, 223, 227, 316, 366, 386, 398–399, 449, 477, 483, 500, 523, 525
   plan_join_ts.py1791094%53, 60, 83–84, 129, 181, 185, 193, 268, 335
   query_plan.py22864%13–21, 30
   query_planner.py4307283%41–42, 65–66, 75, 174, 330, 348–350, 357, 402–405, 458, 486–564, 607–608, 621, 647, 747, 780, 782, 806, 831–833
   query_prepare.py2866179%76, 78, 86–116, 227, 249, 272, 315, 336, 362, 391–445, 448–454, 485, 498–500, 509, 528
   step_result.py14286%7, 12
   steps.py1591690%12, 17, 25, 30–32, 51–53, 61–64, 91–93
   ts_utils.py67691%59, 61, 83–86, 90
   utils.py2422888%60, 81, 106, 112, 127, 139, 151, 154, 166, 194, 207, 222, 228, 233, 240, 242, 247, 260, 265, 271, 277, 291, 308, 338–339, 350–351, 366
mindsdb_sql/render
   sqlalchemy_render.py4616386%56, 91, 93, 105, 110, 127, 129, 131, 133, 195, 212–213, 224–225, 243, 273, 275, 286, 328, 342, 348, 399, 479–483, 513, 528, 551–552, 555–556, 563, 586–597, 617, 650–674, 697, 703, 743–746, 767–770
TOTAL670749793% 

Tests Skipped Failures Errors Time
689 1 💤 0 ❌ 0 🔥 25.961s ⏱️

@ea-rus ea-rus merged commit 410c2f9 into staging Nov 11, 2024
7 checks passed
@ea-rus ea-rus mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

1 participant