Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No aliases to FetchDataframeStep #366

Merged
merged 4 commits into from
Mar 20, 2024
Merged

No aliases to FetchDataframeStep #366

merged 4 commits into from
Mar 20, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Mar 19, 2024

Support query current_timestamp in query:

select current_timestamp from my_pg.branches

Changes:

  • Render: use special functions instead of identifier
  • Planner
    • don't add aliases for selects from database
    • remove alias for ts conditions, they will be copied to other TS queries

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sql
   __about__.py10100%1–10
   __init__.py1292382%43, 47, 93, 110, 113, 134–153, 160–161, 178
mindsdb_sql/parser
   lexer.py165199%243
   logger.py19479%14, 17, 23, 26
   parser.py4563193%48, 53, 73, 77, 81, 87, 91–93, 121–128, 182, 199, 249, 253, 317, 346–347, 367, 378, 491, 526, 557, 567, 581, 657
   utils.py46491%73–79
mindsdb_sql/parser/ast
   base.py36781%13, 28, 31, 49–52
   create.py701086%7–8, 21, 26, 89–94
   drop.py52296%10, 13
   insert.py62592%32, 35–37, 42
   show.py48198%18
   update.py53591%40–42, 75–76
mindsdb_sql/parser/ast/select
   case.py26292%19, 22
   constant.py36197%23
   data.py11282%15, 19
   identifier.py64789%43, 80–85
   native_query.py13192%25
   operation.py121794%27–30, 56, 65, 166, 185
   parameter.py11191%10
   select.py97397%148–153
   star.py12283%8–9
   union.py23196%18
mindsdb_sql/parser/dialects/mindsdb
   create_predictor.py92199%55
   knowledge_base.py40198%71
   lexer.py2552192%336, 338, 340, 352, 354, 356, 362–380
   parser.py9472797%120, 124, 263, 288, 375, 377, 568, 585, 609–610, 753, 806, 860, 877, 1006, 1016, 1054–1055, 1080, 1091, 1227, 1280, 1708, 1716, 1769–1772
mindsdb_sql/parser/dialects/mysql
   lexer.py23674%16, 18, 20, 32, 34, 36
   parser.py6092496%131, 133, 226–227, 326, 356, 373, 423, 427, 501, 511, 549–550, 570, 581, 702, 730, 735–737, 741, 758, 902, 1046
   show_index.py171135%10–12, 15–23, 26–27
mindsdb_sql/planner
   plan_join.py2741296%137, 173, 182, 209, 213, 302, 350, 368, 377–378, 406, 408
   plan_join_ts.py1791094%53, 60, 83–84, 129, 181, 185, 193, 268, 335
   query_plan.py22864%13–21, 30
   query_planner.py3876384%41–42, 65–66, 75, 152, 175, 380, 408–486, 529–530, 543, 569, 631, 661, 689, 714–716
   query_prepare.py2846179%76, 78, 86–116, 227, 249, 272, 315, 336, 360, 389–443, 446–452, 483, 496–498, 507, 526
   step_result.py14286%7, 12
   steps.py1802288%14, 19, 27, 32–34, 55–60, 67–73, 110–115
   ts_utils.py67691%59, 61, 83–86, 90
   utils.py2422789%60, 106, 112, 127, 139, 151, 154, 166, 196, 209, 224, 230, 235, 242, 244, 249, 262, 267, 273, 279, 293, 310, 340–341, 352–353, 368
mindsdb_sql/render
   sqlalchemy_render.py4147781%53, 87, 89, 101, 106, 123, 125, 127, 129, 191, 194–195, 208–209, 220–221, 239, 269, 271, 300, 314, 320, 371, 434–445, 456–460, 490, 505, 510–520, 529–530, 554–565, 584, 607–631, 639, 643, 665–668, 688–691
TOTAL637650992% 

Tests Skipped Failures Errors Time
667 1 💤 0 ❌ 0 🔥 21.690s ⏱️

@ea-rus ea-rus merged commit 6dfcab0 into staging Mar 20, 2024
11 checks passed
@ea-rus ea-rus mentioned this pull request Mar 20, 2024
@ea-rus ea-rus deleted the no-alias branch October 31, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant