Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax/planner updates Feb24 #348

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Syntax/planner updates Feb24 #348

merged 5 commits into from
Feb 2, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Feb 1, 2024

Changes

Copy link

github-actions bot commented Feb 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sql
   __about__.py10100%1–10
   __init__.py24196%21
mindsdb_sql/parser
   lexer.py165199%243
   logger.py19479%14, 17, 23, 26
   parser.py4563193%48, 53, 73, 77, 81, 87, 91–93, 121–128, 182, 199, 249, 253, 317, 346–347, 367, 378, 491, 526, 557, 567, 581, 657
   utils.py46491%73–79
mindsdb_sql/parser/ast
   base.py36781%13, 28, 31, 49–52
   create.py601673%7–8, 49–54, 73–85
   drop.py52296%10, 13
   insert.py62592%32, 35–37, 42
   show.py48198%18
   update.py53591%40–42, 75–76
mindsdb_sql/parser/ast/select
   case.py26292%19, 22
   constant.py35197%22
   data.py11282%15, 19
   identifier.py64789%43, 80–85
   native_query.py13192%25
   operation.py113695%27–30, 56, 65, 166
   parameter.py11191%10
   select.py97397%148–153
   star.py12283%8–9
   union.py23196%18
mindsdb_sql/parser/dialects/mindsdb
   create_file.py19195%14
   create_predictor.py92199%55
   knowledge_base.py40198%71
   lexer.py235697%332, 334, 336, 348, 350, 352
   parser.py9432697%119, 123, 259, 284, 371, 373, 609, 626, 650–651, 777, 829, 883, 900, 1034, 1044, 1082–1083, 1108, 1119, 1259, 1263, 1316, 1444, 1725, 1733
mindsdb_sql/parser/dialects/mysql
   lexer.py23674%16, 18, 20, 32, 34, 36
   parser.py6152396%131, 133, 226–227, 356, 373, 423, 427, 501, 511, 549–550, 570, 581, 710, 738, 743–745, 749, 766, 910, 1056
   show_index.py171135%10–12, 15–23, 26–27
mindsdb_sql/planner
   plan_join.py2631295%136, 172, 181, 208, 212, 301, 349, 367, 376–377, 405, 407
   plan_join_ts.py1791094%53, 60, 83–84, 129, 181, 185, 193, 265, 332
   query_plan.py22864%13–21, 30
   query_planner.py3856384%41–42, 65–66, 75, 152, 177, 382, 410–488, 531–532, 537, 563, 625, 655, 683, 708–710
   query_prepare.py2846179%76, 78, 86–116, 227, 249, 272, 315, 336, 360, 389–443, 446–452, 483, 496–498, 507, 526
   step_result.py14286%7, 12
   steps.py1742287%14, 19, 27, 32–34, 55–60, 67–73, 110–115
   ts_utils.py66691%59, 61, 81–84, 88
   utils.py2414183%60, 106, 112, 127, 139, 151, 154, 166, 196, 209, 224, 230, 235, 242, 244, 249, 254–257, 262, 267, 273, 279, 282–293, 307, 337–338, 349–350, 365
mindsdb_sql/render
   sqlalchemy_render.py3807281%38, 72, 74, 86, 91, 164–165, 178–179, 203, 233, 235, 264, 276, 282, 333, 396–407, 418–422, 452, 467, 472–482, 491–492, 516–527, 546, 569–593, 604–605, 610–611, 622–625, 645–648
TOTAL619048592% 

Tests Skipped Failures Errors Time
664 1 💤 0 ❌ 0 🔥 16.745s ⏱️

@ea-rus ea-rus mentioned this pull request Feb 1, 2024
8 tasks
@ea-rus ea-rus changed the title exclude predict target from model params Syntax/planner updates Feb24 Feb 1, 2024
@ea-rus ea-rus merged commit bee1d9b into staging Feb 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condition to model in join: exclude predict target
1 participant