Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parser to allow no storage to be passed to knowledge base #314

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

dusvyat
Copy link
Contributor

@dusvyat dusvyat commented Oct 19, 2023

fix parser to allow for user to not specify storage in creation of knowledge base

also see PR mindsdb/mindsdb#7886

@dusvyat dusvyat requested review from ea-rus and removed request for ea-rus October 19, 2023 09:28
@dusvyat dusvyat marked this pull request as ready for review October 19, 2023 09:28
@dusvyat dusvyat requested a review from ea-rus October 19, 2023 09:28
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sql
   __about__.py10100%1–10
   __init__.py24196%21
mindsdb_sql/parser
   lexer.py166199%244
   logger.py19479%14, 17, 23, 26
   parser.py4562195%92, 121–128, 182, 199, 317, 346–347, 367, 378, 491, 526, 557, 567, 581, 657
   utils.py46491%73–79
mindsdb_sql/parser/ast
   base.py36489%13, 28, 31, 51
   create.py601673%7–8, 49–54, 73–85
   drop.py52296%10, 13
   insert.py62592%32, 35–37, 42
   show.py48198%18
   update.py53591%40–42, 75–76
mindsdb_sql/parser/ast/select
   case.py26292%19, 22
   constant.py42198%21
   data.py11282%15, 19
   identifier.py64789%43, 80–85
   operation.py113695%27–30, 56, 65, 166
   parameter.py11191%10
   select.py97397%148–153
   star.py12283%8–9
mindsdb_sql/parser/dialects/mindsdb
   create_file.py19195%14
   create_predictor.py88199%54
   knowledge_base.py38197%71
   parser.py8862797%110, 115, 205, 229, 239, 301, 303, 395, 407, 539, 556, 580–581, 707, 757, 806, 823, 955, 965, 1003–1004, 1029, 1040, 1180, 1184, 1238, 1640
mindsdb_sql/parser/dialects/mysql
   lexer.py23674%16, 18, 20, 32, 34, 36
   parser.py6111697%116, 118, 210, 222, 341, 358, 486, 496, 534–535, 555, 566, 695, 751, 895, 1041
   show_index.py171135%10–12, 15–23, 26–27
mindsdb_sql/planner
   query_plan.py22864%13–21, 30
   query_planner.py7215293%47–48, 71–72, 81, 97, 158, 371, 428, 502, 506, 512, 575–583, 633, 717, 756, 765, 798, 803, 831, 836, 849, 851, 868, 872, 900–917, 935–936, 981, 988, 1011–1012, 1053, 1127, 1154, 1180, 1245, 1292, 1317–1319
   query_prepare.py2866278%76, 78, 86–116, 190, 227, 249, 272, 315, 336, 360, 389–443, 446–452, 483, 496–498, 507, 526
   step_result.py14286%7, 12
   steps.py168398%14, 19, 27
   ts_utils.py50296%58, 60
   utils.py2453984%10–22, 59, 84, 123, 141, 153, 165, 168, 180, 210, 223, 238, 244, 249, 256, 258, 263, 268–271, 276, 281, 287, 293, 307, 337–338, 349–350
mindsdb_sql/render
   sqlalchemy_render.py3665286%38, 72, 74, 86, 91, 163–164, 177–178, 202, 232, 234, 263, 275, 281, 332, 396, 444, 459, 469–470, 494–505, 524, 547–571, 582–583, 588–589, 600–603, 623–626
TOTAL589738194% 

Tests Skipped Failures Errors Time
671 1 💤 0 ❌ 0 🔥 23.926s ⏱️

@dusvyat dusvyat requested a review from ea-rus October 19, 2023 12:19
@dusvyat dusvyat requested a review from ea-rus October 19, 2023 12:38
@dusvyat dusvyat merged commit 1dd937b into staging Oct 19, 2023
10 checks passed
@ea-rus ea-rus mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants