fix update from select with using

mindsdb · May 23, 2024 · 803bd05 · 803bd05
1 parent 7c731a1
commit 803bd05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/mindsdb_sql/parser/dialects/mindsdb/parser.py b/mindsdb_sql/parser/dialects/mindsdb/parser.py
@@ -70,7 +70,6 @@ class MindsDBParser(Parser):
        'drop_dataset',
        'union',
        'select',
-       'select_using',
        'insert',
        'update',
        'delete',
@@ -1090,7 +1089,7 @@ def ordering_term(self, p):
         return OrderBy(field=p.identifier, direction='default')
 
     @_('select USING kw_parameter_list')
-    def select_using(self, p):
+    def select(self, p):
         p.select.using = p.kw_parameter_list
         return p.select
 

diff --git a/tests/test_parser/test_base_sql/test_update.py b/tests/test_parser/test_base_sql/test_update.py
@@ -56,6 +56,7 @@ def test_update_simple(self, dialect):
             from                         
              (
                select result, prod_id from table1
+               USING  aaa = "bbb"
              ) as df
             where          
                 table2.prod_id = df.prod_id             
@@ -68,7 +69,8 @@ def test_update_simple(self, dialect):
             },
             from_select=Select(
                 targets=[Identifier('result'), Identifier('prod_id')],
-                from_table=Identifier('table1')
+                from_table=Identifier('table1'),
+                using={'aaa': 'bbb'}
             ),
             from_select_alias=Identifier('df'),
             where=BinaryOperation(op='=', args=[