CREATE KNOWLEDGE_BASE without using

mindsdb · Jan 23, 2024 · 281ca8e · 281ca8e
1 parent df1d790
commit 281ca8e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/mindsdb_sql/parser/dialects/mindsdb/parser.py b/mindsdb_sql/parser/dialects/mindsdb/parser.py
@@ -100,6 +100,7 @@ def query(self, p):
     # -- Knowledge Base --
     @_(
         'CREATE KNOWLEDGE_BASE if_not_exists_or_empty identifier USING kw_parameter_list',
+        'CREATE KNOWLEDGE_BASE if_not_exists_or_empty identifier',
         # from select
         'CREATE KNOWLEDGE_BASE if_not_exists_or_empty identifier FROM LPAREN select RPAREN USING kw_parameter_list',
         'CREATE KNOWLEDGE_BASE if_not_exists_or_empty identifier FROM LPAREN select RPAREN',

diff --git a/tests/test_parser/test_mindsdb/test_knowledgebase.py b/tests/test_parser/test_mindsdb/test_knowledgebase.py
@@ -151,21 +151,20 @@ def test_create_knowledge_base():
     assert ast == expected_ast
 
     # create without USING ie no storage or model
-    # todo currently this is not supported by the parser
-
-    # sql = """
-    #     CREATE KNOWLEDGE_BASE my_knowledge_base;
-    # """
-    # ast = parse_sql(sql, dialect="mindsdb")
-    # expected_ast = CreateKnowledgeBase(
-    #     name=Identifier("my_knowledge_base"),
-    #     if_not_exists=False,
-    #     model=None,
-    #     storage=None,
-    #     from_select=None,
-    #     params={},
-    # )
-    # assert ast == expected_ast
+
+    sql = """
+        CREATE KNOWLEDGE_BASE my_knowledge_base;
+    """
+    ast = parse_sql(sql, dialect="mindsdb")
+    expected_ast = CreateKnowledgeBase(
+        name=Identifier("my_knowledge_base"),
+        if_not_exists=False,
+        model=None,
+        storage=None,
+        from_select=None,
+        params={},
+    )
+    assert ast == expected_ast
 
     # create with params
     sql = """