Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cookies to requests #168

Merged
merged 2 commits into from
Nov 15, 2024
Merged

feat: add cookies to requests #168

merged 2 commits into from
Nov 15, 2024

Conversation

lucas-koontz
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 13, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2035274%33, 101, 104, 112, 120, 138, 156, 166, 169, 173, 175, 177, 179, 181, 183, 245, 258, 262–277, 289, 298–302, 309–310, 356, 364–365, 415, 464–465, 468, 475, 496–498, 502–506
   databases.py45296%109, 137
   handlers.py39197%77
   jobs.py97793%41, 53, 81, 85, 147–150
   knowledge_bases.py1261092%58–61, 155, 254–257, 326, 343
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py64198%160
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2274381%19–29, 35–36, 51, 55, 58–59, 79–81, 102, 105, 112–115, 148–156, 177–178, 213–216, 230–231, 285–290
mindsdb_sdk/utils
   agents.py50492%72, 79–81
   mind.py47470%1–128
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL157626183% 

Tests Skipped Failures Errors Time
28 0 💤 0 ❌ 0 🔥 10.630s ⏱️

@lucas-koontz lucas-koontz self-assigned this Nov 14, 2024
Copy link

@mindsdb-devops mindsdb-devops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -37,7 +37,8 @@ def _raise_for_status(response):


class RestAPI:
def __init__(self, url=None, login=None, password=None, api_key=None, is_managed=False, headers=None):
def __init__(self, url=None, login=None, password=None, api_key=None, is_managed=False,
cookies=None, headers=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what cookie name is going to be used? is it related to authorization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cookies are used to track session. I'll add you the related PRs.

@lucas-koontz lucas-koontz merged commit 20e97f4 into main Nov 15, 2024
5 checks passed
@lucas-koontz lucas-koontz deleted the feat/add-cookies branch November 15, 2024 17:44
@mindsdb mindsdb locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

3 participants