Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge base to api endpoints #167

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Knowledge base to api endpoints #167

merged 5 commits into from
Nov 28, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Nov 11, 2024

Changes:

  • changed insert method:
    • uses http api to send dict or dataframe
    • added insert_query to send query via http api
  • methods switched from sql query to http api:
    • list, get, create, drop
  • added completion method to KB
  • small refactoring of insert files/web

Fix: https://linear.app/mindsdb/issue/ML-188/add-support-for-new-knowledge-base-endpoints-to-python-sdk

Copy link

github-actions bot commented Nov 11, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2035274%33, 101, 104, 112, 120, 138, 156, 166, 169, 173, 175, 177, 179, 181, 183, 245, 258, 262–277, 289, 298–302, 309–310, 356, 364–365, 415, 464–465, 468, 475, 496–498, 502–506
   databases.py45296%109, 137
   handlers.py39197%77
   jobs.py97793%40, 52, 80, 84, 146–149
   knowledge_bases.py108893%53–56, 165, 169, 191–195
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py62198%158
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2444382%19–29, 35–36, 51, 55, 58–59, 79–81, 102, 105, 112–115, 148–156, 177–178, 213–216, 230–231, 285–290
mindsdb_sdk/utils
   agents.py50492%72, 79–81
   mind.py47470%1–128
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL157325984% 

Tests Skipped Failures Errors Time
28 0 💤 0 ❌ 0 🔥 10.847s ⏱️

@ea-rus ea-rus requested a review from tmichaeldb November 12, 2024 14:40
@ea-rus ea-rus marked this pull request as ready for review November 12, 2024 14:40
Copy link
Contributor

@tmichaeldb tmichaeldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out with this! LGTM

@ea-rus ea-rus merged commit bff0f39 into main Nov 28, 2024
5 checks passed
@mindsdb mindsdb locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

2 participants