Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lower Case Naming for File Upload & KB Creation #157

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Conversation

tmichaeldb
Copy link
Contributor

File names & KB names could be implicitly renamed to lower case (since SQL does not differentiate between upper/lower for identifiers) on the backend. So we should just ensure the names are all lowercase before creation & upload.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2035274%33, 101, 104, 112, 120, 138, 156, 166, 169, 173, 175, 177, 179, 181, 183, 245, 258, 262–277, 289, 298–302, 309–310, 356, 364–365, 415, 464–465, 468, 475, 496–498, 502–506
   databases.py45296%109, 137
   handlers.py39197%77
   jobs.py97793%41, 53, 81, 85, 147–150
   knowledge_bases.py1261588%58–61, 155, 159–166, 171–175, 254–257, 326, 343
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py64198%160
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2254281%19–29, 35–36, 51, 54–55, 75–77, 98, 101, 108–111, 144–152, 173–174, 209–212, 226–227, 281–286
mindsdb_sdk/utils
   mind.py43430%1–121
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL152025783% 

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 10.374s ⏱️

@dusvyat dusvyat merged commit 482d1a4 into main Sep 11, 2024
5 checks passed
@ea-rus ea-rus mentioned this pull request Sep 11, 2024
@lucas-koontz lucas-koontz deleted the create_mind-fix branch September 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

3 participants