Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_mind to Use New DataSourceConfig #132

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

tmichaeldb
Copy link
Contributor

@tmichaeldb tmichaeldb commented Jul 17, 2024

This PR adds a more flexible approach to connecting data sources to a mind.

Minds will be able to access files (local, Cloud, URL), databases, and webpages, so they should be configured as such.

Related to ML-95

@tmichaeldb tmichaeldb self-assigned this Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2015175%23, 88, 91, 99, 107, 115, 123, 133, 136, 140, 142, 144, 146, 148, 216, 220–232, 244, 253–257, 264–265, 302, 314–315, 356, 373–375, 390, 395–397, 428–429, 449–451, 455–459
   databases.py45296%109, 137
   handlers.py39197%77
   jobs.py97793%41, 53, 81, 85, 147–150
   knowledge_bases.py1261588%58–61, 151, 155–162, 167–171, 250–253, 322, 339
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py63198%160
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2173882%18–28, 34–35, 50, 53–54, 74–76, 97, 100, 107–110, 143–151, 198, 212–213, 267–272
mindsdb_sdk/utils
   mind.py35350%1–91
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL150224484% 

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 9.274s ⏱️

Copy link
Contributor

@ea-rus ea-rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

@tmichaeldb tmichaeldb merged commit e5a1ac4 into staging Jul 22, 2024
3 checks passed
@dusvyat
Copy link
Contributor

dusvyat commented Jul 22, 2024 via email

@tmichaeldb tmichaeldb mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

3 participants