Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Retrieval Skill for Adding Files to Agents #106

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

tmichaeldb
Copy link
Contributor

Requires this PR to be merged.

Now that we support our new retrieval skill, we should use that by default

@tmichaeldb tmichaeldb requested review from ea-rus and dusvyat April 23, 2024 20:39
@tmichaeldb tmichaeldb self-assigned this Apr 23, 2024
@tmichaeldb tmichaeldb added the enhancement New feature or request label Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py1224563%20, 79, 87, 90, 94, 96, 98, 100, 102, 168–206, 229–231, 252–254, 258–262
   databases.py42295%107, 134
   handlers.py39197%77
   jobs.py97793%41, 53, 81, 85, 147–150
   knowledge_bases.py1241687%58–61, 125, 145, 149–156, 161–165, 244–247, 316, 333
   ml_engines.py42393%94, 126, 128
   models.py2111991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 403, 497, 505, 524, 540, 548, 573, 577, 590
   projects.py63198%167
   query.py13192%14
   skills.py53787%43, 45, 49, 59, 76–80, 122
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py1793183%16–26, 32–33, 48, 69–71, 92, 95, 102–105, 156–164, 330–340
TOTAL124015088% 

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 8.934s ⏱️

@ea-rus
Copy link
Contributor

ea-rus commented Apr 24, 2024

This PR is refering to https://github.com/mindsdb/mindsdb/pull/9119/files
But in SDK PR I see only changes in KB skill and don't see anything about it in mindsdb PR
They are really dependent?

@tmichaeldb tmichaeldb merged commit cf74f06 into staging Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants