Skip to content

Conversation

StpMax
Copy link
Collaborator

@StpMax StpMax commented Sep 10, 2025

Allow to import in ES6 style:

import MindsDB from "mindsdb-js-sdk";

Also fixed few typos in the code.

Note: some of changed authored by LLM

Copy link

github-actions bot commented Sep 10, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@StpMax StpMax requested a review from setohe0909 September 10, 2025 13:29
@StpMax
Copy link
Collaborator Author

StpMax commented Sep 10, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 10, 2025
Copy link

🔒 Entelligence AI Vulnerability Scanner

❌ Security analysis failed: Security analysis failed: 403: blocked: error while getting the team: team is blocked

Copy link

Review Summary

🏷️ Draft Comments (2)

Skipped posting 2 draft comments that were valid but scored below your review threshold (>=13/15). Feel free to update them here.

fix-esm-imports.js (1)

44-57: fixImportsInFile and fixImportsInDirectory do not handle symlinked directories or files, which can cause infinite recursion or unintended file modifications if symlinks are present in ./dist/esm.

📊 Impact Scores:

  • Production Impact: 4/5
  • Fix Specificity: 4/5
  • Urgency Impact: 3/5
  • Total Score: 11/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In fix-esm-imports.js, lines 44-57, the code does not check for symbolic links when traversing directories, which can cause infinite recursion or unintended file modifications if symlinks are present. Update the loop to skip files or directories that are symbolic links by checking file.isSymbolicLink() and continuing the loop if true.

src/tables/table.ts (1)

37-37: removeTable method now calls deleteTable on the API client, which may unintentionally delete the table instead of removing it from the integration if deleteTable and removeTable have different semantics.

📊 Impact Scores:

  • Production Impact: 4/5
  • Fix Specificity: 2/5
  • Urgency Impact: 3/5
  • Total Score: 9/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In src/tables/table.ts, line 37, the `removeTable` method now calls `deleteTable` on the API client. If `deleteTable` and `removeTable` have different semantics (e.g., one deletes the table entirely and the other just removes it from an integration), this could cause data loss or incorrect behavior. Please restore the call to `removeTable` instead of `deleteTable`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants