Skip to content

Commit

Permalink
Merge pull request #106 from ArnavK-09/patch-1
Browse files Browse the repository at this point in the history
patch(modelsRestApiClient.ts): type conversion for params
  • Loading branch information
mpacheco12 authored Nov 13, 2024
2 parents d7e7dbe + 2d6b149 commit 16d40aa
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/models/modelsRestApiClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export default class ModelsRestApiClient extends ModelsApiClient {
return whereClause;
}

private makeUsingClause (using: string | Array<string>): string {
private makeUsingClause (using: string | Array<string>): string {
if (!using) {
return '';
}
Expand Down Expand Up @@ -507,7 +507,7 @@ export default class ModelsRestApiClient extends ModelsApiClient {
): Promise<void> {
const deleteQuery = `DROP MODEL ${mysql.escapeId(project)}.${mysql.escapeId(
model,
)}.${mysql.escapeId(v)}`;
)}.${mysql.escapeId(v.toString())}`;
const sqlQueryResult = await this.sqlClient.runQuery(deleteQuery);
if (sqlQueryResult.error_message) {
throw new MindsDbError(sqlQueryResult.error_message);
Expand All @@ -534,4 +534,4 @@ export default class ModelsRestApiClient extends ModelsApiClient {
new ModelVersion(project, { ...model, version: v })),
);
}
}
}

0 comments on commit 16d40aa

Please sign in to comment.