Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate config for preprocessing config on kb create #67

Merged
merged 1 commit into from
Dec 12, 2024
Merged

separate config for preprocessing config on kb create #67

merged 1 commit into from
Dec 12, 2024

Conversation

dusvyat
Copy link
Contributor

@dusvyat dusvyat commented Dec 12, 2024

No description provided.

@trag-bot Trag Bot
Copy link

trag-bot bot commented Dec 12, 2024

@trag-bot didn't find any issues in the code! ✅✨

@trag-bot Trag Bot
Copy link

trag-bot bot commented Dec 12, 2024

Pull request summary

  • Added a new optional attribute preprocessing_config to the KnowledgeBaseConfig class to allow configuration of preprocessing settings.
  • Updated the create method to include the preprocessing configuration in the create_request if it is provided in the KnowledgeBaseConfig.
  • Ensured that the preprocessing configuration is serialized using the model_dump() method before being added to the create_request.

@dusvyat dusvyat requested a review from tmichaeldb December 12, 2024 13:21
QuantumPlumber
QuantumPlumber approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@QuantumPlumber QuantumPlumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichaeldb tmichaeldb merged commit 9af5cb5 into main Dec 12, 2024
6 checks passed
@tmichaeldb tmichaeldb deleted the add-support-for-kb-preprocessing-config-on-kb-create branch December 12, 2024 17:31
@mindsdb mindsdb locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@QuantumPlumber QuantumPlumber QuantumPlumber approved these changes

@tmichaeldb tmichaeldb Awaiting requested review from tmichaeldb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusvyat @QuantumPlumber @tmichaeldb