Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource name validation #48

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

Better-Boy
Copy link
Contributor

@Better-Boy Better-Boy commented Oct 23, 2024

Validation for datasource name while creation.

Fixes #46

@Better-Boy Better-Boy changed the title Update datasources.py Datasource name validation Oct 23, 2024
@Better-Boy Better-Boy marked this pull request as ready for review October 23, 2024 14:51
@Better-Boy
Copy link
Contributor Author

@ea-rus can you please review this PR?

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets solve the conflicts before we merge @Better-Boy

@Better-Boy
Copy link
Contributor Author

Lets solve the conflicts before we merge @Better-Boy

Resolved.

@ZoranPandovski ZoranPandovski merged commit 27701de into mindsdb:main Nov 19, 2024
5 checks passed
@mindsdb mindsdb locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Datasource name validation
3 participants