Drop column with no information #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paxcema
approved these changes
Nov 8, 2021
hakunanatasha
suggested changes
Nov 10, 2021
lightwood/helpers/text.py
Outdated
| @@ -210,7 +210,12 @@ def get_identifier_description_mp(arg_tup): | |||
|
|
|||
| def get_identifier_description(data, column_name, data_dtype): | |||
There was a problem hiding this comment.
type hint
data: Iterable, column_name: str, data_dtype: str
| @@ -210,7 +210,12 @@ def get_identifier_description_mp(arg_tup): | |||
|
|
|||
| def get_identifier_description(data, column_name, data_dtype): | |||
| data = list(data) | |||
There was a problem hiding this comment.
why do we make this a list?
There was a problem hiding this comment.
if it's already in a series form you can simply do something like len(data.unique())
lightwood/helpers/text.py
Outdated
| if nr_unique == 1: | ||
| return 'No Information' | ||
|
|
||
| unquie_pct = nr_unique / len(data) |
| if nr_unique == 1: | ||
| return 'No Information' | ||
|
|
||
| unquie_pct = nr_unique / len(data) | ||
|
|
||
| spaces = [len(str(x).split(' ')) - 1 for x in data] | ||
| mean_spaces = np.mean(spaces) |
There was a problem hiding this comment.
why are we doing this?
There was a problem hiding this comment.
In order to mark the column for dropping under the "identifier / foreign-keys" rule, if this function returns a string (rather than None) the column is dropped, maybe the interface is confusing. And maybe we should broaden the definition of "identifier" to something like "no_information" ?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping columns that don't have any information (a single unique value)
Currently no test for this since
get_identifier_descriptionhas no tests (maybe todo for later) and this is so dumb it's not the first thing I'd want to test, see mindsdb/type_infer#31