feat: added prospector code analysis tool

[vickywane]

This pull request will fix this issue.

This pull request adds Prospector as a static code analysis tool to run an analysis each time a PR is opened through the use of GitHub actions.

[George3d6]

This can go inside here https://github.com/mindsdb/lightwood/blob/staging/tests/requirements.txt instead

[vickywane]

Alright.

That works.

[George3d6]

Could you source these from the .flake8 file? Alt jut disable this check since we already run falke8 automatically to release

[vickywane]

Alright.

[vickywane]

I have disabled the checks.

I think they can be added later.

[George3d6]

Afaict the analysis finds nothing:

         Started: 2021-10-25 22:30:27.680064
        Finished: 2021-10-25 22:30:27.732671
      Time Taken: 0.05 seconds
       Formatter: grouped
        Profiles: default, no_doc_warnings, no_test_warnings, strictness_medium, strictness_high, strictness_veryhigh, no_member_warnings
      Strictness: None
  Libraries Used: 
       Tools Run: dodgy, mccabe, pep8, profile-validator, pyflakes, pylint
  Messages Found: 0

Which is kind of strange... as in, I'm worried it might not be analyzing all the codebase. Can you intentionally add an error somewhere to double check that it works?

[vickywane]

Which is kind of strange... as in, I'm worried it might not be analyzing all the codebase. Can you intentionally add an error somewhere to double check that it works?

Quite strange. Locally, i can see output from the run. See screenshot ;

[vickywane]

@George3d6 I just refactored the prospector to save the output in a JSON and upload it to GitHub artifiacts. You can view it in the artifacts tab for a CI run.

Are you okay with this approach?

[George3d6]

I think this approach work, but could you link to the artefact generated by this execution? -- currently I don't see anything: https://github.com/mindsdb/lightwood/runs/4023079796?check_suite_focus=true

[George3d6]

Any updates on this? I feel like there may have been a few merging issues along the way :))

Feel free to open a new PR if you want.

[vickywane]

I’ll pull the new merges into my branch.

The underlying problem is that the Github CI checks are not printing out the analysis result to the console, making it difficult to work with.

[George3d6]

Closing as inactive for now, might be better to just start a new PR anyway, since this branch resulted in a very odd diff.