Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extras requirements files #1199

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Include extras requirements files #1199

merged 1 commit into from
Dec 12, 2023

Conversation

hamishfagg
Copy link
Contributor

@hamishfagg hamishfagg commented Dec 12, 2023

Fixes issues with torchvision missing from mindsdb docker files

Extras requirements files are not included in the lightwood pip package, so setup.py can't enumerate them, and when users install e.g. lightwood[all_extras] there are packages missing

Copy link
Contributor

@paxcema paxcema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@hamishfagg hamishfagg merged commit 430cf6d into staging Dec 12, 2023
12 checks passed
@hamishfagg hamishfagg deleted the fix_extras branch December 12, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants