Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add propsector code analysis to CI run #1021

Closed
wants to merge 3 commits into from
Closed

feat: add propsector code analysis to CI run #1021

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d884a
feat: add propsector code analysis to CI run
vickywane Oct 16, 2022
6b2201f
update: configure static analysis workflow to output YAML into PR
vickywane Oct 21, 2022
5e64381
update: configure static analysis workflow to output YAML into PR
vickywane Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Static Code Analysis Of Codebase
on: [push, pull_request]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for now we can just run this on pull_request


jobs:
static_analysis:
runs-on: ubuntu-latest
steps:
- name: Checkout and set up
uses: actions/checkout@v3

- name: Install Python for analysis
uses: actions/setup-python@v4
with:
python-version: 'pypy3.9'

- name: Install dependencies for analysis
run: |
python -m pip install --upgrade pip
pip install prospector
- name: Run static code analysis using Prospector tool
run: prospector --zero-exit > static_analyis.json

- name: Deploy Static Analysis Result to GitHub Artifacts
uses: actions/upload-artifact@v2
with:
name: static_analysis_result
path: static_analyis.json
1 change: 1 addition & 0 deletions tests/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
prospector==1.7.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I don't think we need this right? The CI script manually installs it, anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is installed in the gh action env