Skip to content

Commit

Permalink
Upgrade NLTK (#1247)
Browse files Browse the repository at this point in the history
* Upgrade NLTK

* Install nltk data before running tests

* Use poetry env

* Don't trigger benchmarks
  • Loading branch information
ZoranPandovski authored Feb 13, 2025
1 parent e0c4448 commit 0b88398
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 10 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/benchmark_check.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Benchmark Result Check Lightwood

on:
pull_request:
branches:
- main
#on:
# pull_request:
# branches:
# - main

jobs:
check:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/lightwood.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ jobs:
- name: Lint with flake8
run: |
poetry run python -m flake8 .
- name: Install NLTK data
run: |
poetry run python -m nltk.downloader punkt
poetry run python -m nltk.downloader punkt_tab
poetry run python -m nltk.downloader stopwords
- name: Test with unittest
run: |
# Run all the "standard" tests
Expand Down
10 changes: 5 additions & 5 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type_infer = ">=0.0.15"
dataprep_ml = ">=24.5.1.2,<24.6.1.0"
mindsdb-evaluator = ">=0.0.13"
numpy = ">1.23.0"
nltk = ">=3.8, <3.9"
nltk = ">=3.9"
pandas = ">=2.0.0, <2.1.0"
torch = ">=2.4.1"
requests = ">=2.0.0"
Expand Down

0 comments on commit 0b88398

Please sign in to comment.