Add settings_local.json override system#678
Open
Fuzzwah wants to merge 1 commit intomindcraft-bots:developfrom
Open
Add settings_local.json override system#678Fuzzwah wants to merge 1 commit intomindcraft-bots:developfrom
Fuzzwah wants to merge 1 commit intomindcraft-bots:developfrom
Conversation
- Load settings_local.json on top of defaults in settings.js - Add settings_local.json to .gitignore - Include example settings_local.json.example file - Document feature in README.md This allows per-machine settings without modifying tracked files.
Contributor
|
@Fuzzwah Can you explain why this would be better than just copying your |
Author
|
@Sweaterdog Because as I'm making changes to the code, I'm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for a
settings_local.jsonfile that overrides default settings without modifying tracked files.Problem
When developing or running Mindcraft on different machines, you need different settings (host, port, profiles, etc.). Currently this requires modifying
settings.js, which causes git conflicts when switching branches or pulling updates.Solution
settings_local.jsonon top of defaults insettings.jsif it existssettings_local.jsonto.gitignoreso it's never trackedsettings_local.json.exampleas a templateUsage
cp settings_local.json.example settings_local.json # Edit with your local settings node main.jsExample
settings_local.json:{ "minecraft_version": "1.21.8", "host": "192.168.1.100", "port": 25565, "auto_open_ui": false, "profiles": [ "./profiles/gemini.json" ] }Benefits