WMSDK-435: Fix pending callbacks #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes pending callback issues by introducing an asynchronous initialization flow using _initFuture.
- Introduces _initFuture to serialize initialization and callback execution.
- Copies pending callbacks and operations to safely iterate during processing.
- Ensures that various getter methods wait for initialization to complete before invoking platform methods.
Comments suppressed due to low confidence (2)
mindbox_platform_interface/lib/src/types/mindbox_method_handler.dart:117
- [nitpick] Consider standardizing the null handling behavior for platform channel calls. For example, the getToken method uses a null-coalescing operator while getDeviceUUID does not. If a consistent behavior is desired, align these implementations.
void getDeviceUUID({required Function(String uuid) callback}) async {
mindbox_platform_interface/lib/src/types/mindbox_method_handler.dart:171
- [nitpick] Consider using the negation operator (!custom) for clarity and to align with common coding practices.
if (custom == false && (_inAppClickHandler != null || _inAppDismissedHandler != null)) {
| @@ -73,11 +81,15 @@ class MindboxMethodHandler { | |||
| _setMethodCallHandler(); | |||
| } | |||
|
|
|||
| for (final callbackMethod in _pendingCallbackMethods) { | |||
| final pendingCallbackMethodsCopy = | |||
There was a problem hiding this comment.
А зачем нам этот код, если методы сработают только после инициализации? Т.е. списки будут пустыми
sergeysozinov
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/WMSDK-435