-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Refactor the expression grammar to improve parsing performance #39875
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Cai Zhang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xiaocai2333 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Benchmark: 100 range expressions now parse in 1.3ms, down from 11ms.
|
Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333 go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39875 +/- ##
==========================================
- Coverage 80.11% 80.08% -0.03%
==========================================
Files 1486 1488 +2
Lines 205387 205655 +268
==========================================
+ Hits 164540 164701 +161
- Misses 34919 35011 +92
- Partials 5928 5943 +15
|
@xiaocai2333 E2e jenkins job failed, comment |
issue: #36672
Refactored the ANTLR g4 grammar to improve parsing efficiency:
These changes result in faster parser generation and runtime performance.