-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add siliconflow text embedding #39867
base: master
Are you sure you want to change the base?
Conversation
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@junjiejiangjjj go-sdk check failed, comment |
rerun go-sdk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39867 +/- ##
===========================================
+ Coverage 69.39% 79.76% +10.37%
===========================================
Files 302 1502 +1200
Lines 27077 207583 +180506
===========================================
+ Hits 18790 165579 +146789
- Misses 8287 35974 +27687
- Partials 0 6030 +6030
|
/assign @zhengbuqian @liliu-z |
} | ||
|
||
func NewSiliconflowEmbeddingProvider(fieldSchema *schemapb.FieldSchema, functionSchema *schemapb.FunctionSchema) (*SiliconflowEmbeddingProvider, error) { | ||
fieldDim, err := typeutil.GetDim(fieldSchema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking form the api doc they do not support provide dim in the request, what is the dim of those embedding models of silliconflow?
if each of their models have a constant dim, should we enforce this earlier? in the current impl if the user sets a incorrect dim, the error is deferred until after some data was embeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, there is no check at the creation stage to see if field dim and model dim are consistent, only at the runtime stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later we can consider adding relevant checks in the creation phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: junjie.jiang <[email protected]>
d2d8aef
to
42ced4a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: junjiejiangjjj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@junjiejiangjjj cpp-unit-test check failed, comment |
rerun cpp-unit-test |
/lgtm |
#35856