Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Introduce batch subscription in msgdispatcher #39863

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

Introduce a batch subscription mechanism in msgdispatcher: the msgdispatcher now includes a vchannel watch task queue, where all vchannels in the queue will subscribe to the MQ only once and pull messages from the oldest vchannel checkpoint to the latest.

issue: #39862

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Feb 13, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 13, 2025
Copy link
Contributor

mergify bot commented Feb 13, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 13, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (c917fe4) to head (e288697).
Report is 1 commits behind head on master.

Current head e288697 differs from pull request most recent head 606b824

Please upload reports for the commit 606b824 to get more accurate results.

❌ Your project check has failed because the head coverage (69.58%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (c917fe4) and HEAD (e288697). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c917fe4) HEAD (e288697)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39863       +/-   ##
===========================================
- Coverage   79.76%   69.58%   -10.19%     
===========================================
  Files        1500      305     -1195     
  Lines      207393    27344   -180049     
===========================================
- Hits       165435    19027   -146408     
+ Misses      35927     8317    -27610     
+ Partials     6031        0     -6031     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.58% <ø> (-0.05%) ⬇️
Go ∅ <ø> (∅)

see 1205 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 13, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants