clean up

Signed-off-by: shaoting-huang <[email protected]>
milvus-io · Feb 14, 2025 · 9718911 · 9718911
1 parent 280ab80
commit 9718911
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/internal/core/src/segcore/packed_reader_c.cpp b/internal/core/src/segcore/packed_reader_c.cpp
@@ -44,7 +44,7 @@ NewPackedReader(char** paths,
             needed_columns.emplace(i);
         }
         auto reader = std::make_unique<milvus_storage::PackedRecordBatchReader>(
-            *trueFs, truePaths, trueSchema, needed_columns, buffer_size);
+            trueFs, truePaths, trueSchema, needed_columns, buffer_size);
         *c_packed_reader = reader.release();
         return milvus::SuccessCStatus();
     } catch (std::exception& e) {

diff --git a/internal/core/thirdparty/milvus-storage/CMakeLists.txt b/internal/core/thirdparty/milvus-storage/CMakeLists.txt
@@ -14,7 +14,7 @@
 # Update milvus-storage_VERSION for the first occurrence
 milvus_add_pkg_config("milvus-storage")
 set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "")
-set( milvus-storage_VERSION ac656a9 )
+set( milvus-storage_VERSION e785c98 )
 set( GIT_REPOSITORY  "https://github.com/shaoting-huang/milvus-storage.git")
 message(STATUS "milvus-storage repo: ${GIT_REPOSITORY}")
 message(STATUS "milvus-storage version: ${milvus-storage_VERSION}")

diff --git a/internal/storage/serde_events_v2.go b/internal/storage/serde_events_v2.go
@@ -85,9 +85,7 @@ func NewPackedRecordReader(paths []string, schema *schemapb.CollectionSchema, bu
 func NewPackedDeserializeReader(paths []string, schema *schemapb.CollectionSchema,
 	bufferSize int64, pkFieldID FieldID,
 ) (*DeserializeReader[*Value], error) {
-	fmt.Println("create new packed reader")
 	reader, err := NewPackedRecordReader(paths, schema, bufferSize)
-	fmt.Println("!!! err: ", err)
 	if err != nil {
 		return nil, err
 	}

diff --git a/internal/storage/serde_events_v2_test.go b/internal/storage/serde_events_v2_test.go
@@ -45,8 +45,9 @@ func TestPackedSerde(t *testing.T) {
 			group = append(group, i)
 		}
 		columnGroups := [][]int{group}
-
-		writer, err := NewPackedSerializeWriter(paths, schema, bufferSize, 0, columnGroups, 7)
+		multiPartUploadSize := int64(0)
+		batchSize := 7
+		writer, err := NewPackedSerializeWriter(paths, schema, bufferSize, multiPartUploadSize, columnGroups, batchSize)
 		assert.NoError(t, err)
 
 		for i := 1; i <= size; i++ {