feat: clean up cmake and move go part to Milvus #168
Conversation
shaoting-huang
commented
Jan 19, 2025
shaoting-huang
commented
- move go part to Milvus
- support azure compile flag
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
storagev2_cpp_only
branch
from
9804212 to
9f70251
Compare
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
storagev2_cpp_only
branch
from
b399fdd to
c20578d
Compare
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
storagev2_cpp_only
branch
from
02359cf to
5deb556
Compare
Signed-off-by: shaoting-huang <[email protected]>
| @@ -11,3 +11,4 @@ go/.idea/* | |||
| compile_commands.json | |||
| CMakeUserPresets.json | |||
| .vscode/* | |||
| go/internal/core/output/* | |||
|
|
||
| option(WITH_UT "Build the testing tree." ON) | ||
| option(WITH_UT "Build the testing tree." OFF) |
There was a problem hiding this comment.
Can we still have UT if this option is turned off?
There was a problem hiding this comment.
test bin is moved into build/Release/test
cpp/CMakeLists.txt
Outdated
| @@ -19,57 +19,65 @@ if (WITH_OPENDAL) | |||
| endif() | |||
|
|
|||
| find_package(Boost REQUIRED) | |||
| include_directories(${Boost_INCLUDE_DIRS}) | |||
There was a problem hiding this comment.
I believe the find_package contains the include_directories primitive already, so it is not necessary to call it explicitly.
| #include "milvus-storage/common/result.h" | ||
| #include "milvus-storage/storage/options.h" |
There was a problem hiding this comment.
It is strange to include the root path in those .h code, we could either set cpp/include/milvus-storage/ as include path, or just remove the milvus-storage subdir.
Signed-off-by: shaoting-huang <[email protected]>
|
/lgtm |
shaoting-huang
changed the title
