Backport terminal reliability, WebGL, and responsive PWA support - #9
Merged
Conversation
Adopt conservative output, daemon, and renderer fixes while adding an installable responsive shell without reviving reverted experiments.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| const end = trimmed.indexOf("]"); | ||
| return end === -1 ? trimmed : trimmed.slice(0, end + 1); | ||
| } | ||
| if (trimmed.includes(":") && !trimmed.includes(".")) return `[${trimmed}]`; |
There was a problem hiding this comment.
Suggested change
| if (trimmed.includes(":") && !trimmed.includes(".")) return `[${trimmed}]`; | |
| // Bare IPv6 addresses (e.g. "::1", "0:0:0:0:0:0:0:1") always contain 2+ | |
| // colons; a "hostname:port" pair contains exactly one colon. Only bracket | |
| // the former so we don't mangle dot-less hosts like "localhost:3417". | |
| const colonCount = (trimmed.match(/:/g) ?? []).length; | |
| if (colonCount >= 2) return `[${trimmed}]`; |
stripPort's bare-IPv6 heuristic misclassifies dot-less host:port values (e.g. localhost:3417) as IPv6, causing loopback enforcement to return 403 for normal localhost:<port> requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
nr buildpnpm test(366 tests)pnpm lintpnpm typecheckpnpm formatandpnpm format --check