A warning when a css resource could not be downloaded & apply styles only to elements within (and itself) the body #395
Conversation
horch004
changed the title
| try | ||
| { | ||
| return cssSource.GetCss(); | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| _warnings.Add(ex.Message); | ||
| return string.Empty; | ||
| } |
There was a problem hiding this comment.
I'm honestly a bit torn on this change. If your html needs a CSS source and it is not available, aren't we breaking things by ignoring that and silently moving ahead?
There was a problem hiding this comment.
I'm a bit confused. When a stylesheet contains bogus or bad css the parser silently ignores it, but when the url is not found (e.g. someone deleted it) the whole process exits with an exception?
The purpose of adding a warning is that the caller can know something is wrong, but that the process of inlining is not stopped. There might be other stylesheets and/or style nodes involved that can be processed.
Now we have to proceed with emailing without any inline style when such an exception occurs because a client forgot to edit his email template after removing a stylesheet from its website.
There was a problem hiding this comment.
(horch004 is my private github. whorchner from my work)
…ied to the html element, head element and elements in the head like script, link etc. To avoid this behaviour only the elements from the body (and itself) are selected to be matched.
…eption when a resource could not be downloaded.
Let GetCssBlocks add a warning to the list instead of throwing an exception when a resource could not be downloaded.
With an All (*) selector in the stylesheet, the css rule is also applied to the html element, head element and elements in the head like script, link etc. To avoid this behaviour only the elements from the body (and itself) are selected to be matched.
Maybe there is another way not to match the all selector to the elements above the body, but this was a quick fix for us.