-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Race condition fix for issue #257 #259
base: master
Are you sure you want to change the base?
Conversation
6eda6f8
to
4c44692
Compare
minor note: |
Thanks Rob, let me make that change |
@RobTillaart @tdwilson Can you guys sanity check this? |
Probably later this week, I have some catching up to with some other projects. |
Hey @RobTillaart, thanks for your getting back to me. I’ve been digging through my project cabinets but, unfortunately, I can’t find the test rig I built for exactly this purpose. Tim also got back to me, although it may be a few weeks before he can do any testing on his end. In the meantime, I’m considering building a small test rig that would automatically sanity-test changes like these. Given all the Arduino libraries you’ve worked on, do you happen to have a similar setup already? I’d appreciate any insight or suggestions you might have. |
The .github/workflows has three actions defined
The detailed output of these actions can be seen here (and as green ticks e.g. in a PR) Note: The boards used for compilation are defined in the file .arduino-ci.yml (note the . at the begin) Compiling the examples at least learns that the code of the library is syntactically correct and compiles. Compilation only is however not a unit test. Finally in my A1301 repo / develop branch (my playground) I have a first try of the platformIO test runner. |
feat(license): migrate to MIT license
feat(error-handling): add retry mechanism for temperature readings
fix(device-search): improve address retrieval reliability
docs(api): update function documentation
test(temperature): enhance temperature reading reliability
refactor(device-handling): improve device management