Skip to content

Commit

Permalink
[eglib] Fixed file being created without read/write permission on Win…
Browse files Browse the repository at this point in the history
…dows.

This bug manifested itself as files being written to disk with 0 bytes.

Fixes the AOT compiler on Windows not working properly.

https://bugzilla.xamarin.com/show_bug.cgi?id=27900
  • Loading branch information
tritao committed Mar 12, 2015
1 parent ec4fed0 commit a678f96
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eglib/src/gfile-win32.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ int mkstemp (char *tmp_template)
utf16_template = _wmktemp( utf16_template);
if (utf16_template && *utf16_template) {
/* FIXME: _O_TEMPORARY causes file to disappear on close causing a test to fail */
fd = _wopen( utf16_template, _O_BINARY | _O_CREAT /*| _O_TEMPORARY*/ | _O_EXCL, _S_IREAD | _S_IWRITE);
fd = _wopen( utf16_template, _O_BINARY | _O_CREAT /*| _O_TEMPORARY*/ | _O_RDWR | _O_EXCL, _S_IREAD | _S_IWRITE);
}

/* FIXME: this will crash if utf16_template == NULL */
Expand Down

0 comments on commit a678f96

Please sign in to comment.