Improve type of defaultOptions #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, why did you disable/remove the issues 😢 |
miki995
approved these changes
Feb 7, 2025
aceArt-GmbH
force-pushed
the
improveTypes
branch
from
9e0e468 to
1be5c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this fork.
While trying to use it, I was not sure what the option keys for
defaultOptionsare called and which exist.So I added the type to it. Inspired by https://github.com/go-gitea/gitea/blob/063c23e1bcf52fde5bda82d0c1dbe7dd04e2771f/web_src/js/features/codeeditor.ts#L8-L11
This might be a breaking change, but actually just fixes types
Does
requireConfigneed this too?Do you want to use this type in the rest of the component? Like https://github.com/miki995/ngx-monaco-editor-v2/blob/master/projects/editor/src/lib/editor.component.ts#L41