fix(packaging): strip pip direct_url.json from the frozen CLI - #176
Merged
Conversation
pip install . into the build venv writes a PEP 610 direct_url.json into agentacct-*.dist-info recording the absolute local build path (file:///Users/<name>/.../worktrees/...); --collect-all copies it into the frozen bundle, so the shipped DMG leaked the builder's account name and build path. It has no runtime purpose in a frozen bundle — delete it after freezing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frozen CLI bundled inside the DMG shipped
_internal/agentacct-*.dist-info/direct_url.json, which pip writes onpip install .and records the absolute local build path (file:///Users/<name>/.../worktrees/...) — leaking the builder's account name and path inside the public DMG.--collect-all agentacctcopied that dist-info into the bundle.Fix: after PyInstaller freezes the bundle, delete every
direct_url.jsonfrom the output. It has no runtime purpose in a frozen onedir bundle. Verified the pattern matches the real leak in the currently-shipped app. Packaging-script only; no Python/Swift change. Takes effect on the next DMG rebuild.