Make dashboard readable at maximum accessibility text - #161
Open
FZ2000 wants to merge 4 commits into
Open
Conversation
…ty' into codex/dashboard-accessible-layout # Conflicts: # apps/agentacct/Sources/agentacct/DashboardPane.swift
This was referenced Aug 28, 2026
# Conflicts: # apps/agentacct/Sources/agentacct/DashboardPane.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect in one sentence
Makes the hardened Dashboard readable at very large and maximum accessibility text, including retained-error states, without changing its normal-size hierarchy or data contract.
Stack position
6 of 6: #153 → #155 → #157 → #159 → #160 → #161 (this accessibility follow-up).
This branch is based on current #160 head
fbd6c69, notmain. The stack is an alternative to standalone #152.Central behavior
DynamicTypeSizedirectly and apply explicit macOS scaling. This replaces the ineffective@ScaledMetricassumption found during native-host testing.xLargeremains the last compact two-column/table state. At.xxLargeand above, the brief, signal rail, Recent Work, card headers, and usage history reflow before fixed geometry becomes unsafe.Review order
DashboardFontRole,DashboardFontModifier, anddashboardUsesAccessibilityLayoutinDashboardPane.swift.DashboardSnapshotHarness.swift.xLarge,xxLarge, accessibility5 light/dark, and accessibility5 retained-error.Verification at current head
70acf39swift test: 155 executed, 5 expected opt-in visual skips, 0 failures.DashboardInteractionTests: 51 passed, including native-host font growth and thexLarge/xxLargetransition.DashboardSnapshotHarnessTests: 10 passed, including full-content clipping rejection and maximum-text retained-error coverage../Scripts/visual-snapshots verify: About, Dashboard, Menu, Usage, and Work all match the pinned canonical renderer.swift build -c release: passed.git diff --checkis clean.Current-head GitHub CI: Python 3.11/3.12/3.13 and macOS app/snapshot jobs all passed.
Scope and validation boundary
This PR is intentionally Dashboard-local. Data truth, pagination, retained-error, and request-race behavior live in #160. Shared top-bar typography remains compact and fully visible at the supported 960-point minimum, but app-wide typography migration is not part of this change.
Canonical snapshots and native-host measurements prove deterministic geometry and font growth; they do not substitute for a live manual VoiceOver traversal or keyboard-focus smoke. No PR in this stack is merged by this change.