Make Sources health fail closed - #158
Open
FZ2000 wants to merge 3 commits into
Open
Conversation
…osed-state # Conflicts: # apps/agentacct/Sources/agentacct/MainWindow.swift
…osed-state # Conflicts: # apps/agentacct/Tests/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect in one sentence
Makes Sources health fail closed: a current ingestion error always outranks retained success, so old healthy rows and watcher state cannot look current.
State contract
What changes
SourcesPresentationStategives the current request result precedence.DashboardStore.refreshIngestion()owns an independent refresh/error/freshness lane.Review order
Verification at current head
2085312main(4ab2547); the only conflict combined Setup and Sources in the documented visual-suite inventory.swift test— 124 executed, 7 expected opt-in visual skips, 0 failures.SetupVisualRegressionTestsandSourcesVisualRegressionTests— all references match locally on the pinned renderer.swift build -c release— passed.git diff --check origin/main...HEAD— clean.Scope
This changes source-health presentation and refresh isolation only. The pre-existing minimum-width truncation of long verifier descriptions remains out of scope.