Verify exp independently of signature #389
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Verify exp independently of signature. Checking the expiry of the token can be valuable regardless of verification of the signature. Implicitly verifying it unless
--ignore-exp
is specified seems to be the natural way of doing it in this tool.My use case is this: I want to keep a locally cached JWT until it has expired, and only then mint a new one. The signature is implicitly trusted, I only have to check the expiry.
Preflight checklist
$ cargo fmt
)$ cargo clippy
)Further notes
I'll be happy to write a test if the feature is accepted and a test is deemed necessary.
I have not added documentation. In fact, the way I read the current documentation leads me to believe that the functionality I have added is already the way it works.