fix: don't restore the previous buffer when yazi is closed #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did not cause any issues though
Sometimes when using vertical splits, I noticed that when yazi is closed, one of the splits switches to a different buffer. I was unable to reproduce this issue consistently, but I have had this happen every once in a while for the last two weeks. It seems like I added some logic to on_yazi_exited that restores the previous buffer, but I don't think that's necessary - it does not seem to be doing anything. I'm hoping this will resolve the issue and not cause any (untested) features to break, but I think it should be quite safe.
mikavilpas
force-pushed
the
previous-buf
branch
from
9489862 to
4ed8134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: don't restore the previous buffer when yazi is closed
Sometimes when using vertical splits, I noticed that when yazi is
closed, one of the splits switches to a different buffer. I was unable
to reproduce this issue consistently, but I have had this happen every
once in a while for the last two weeks.
It seems like I added some logic to on_yazi_exited that restores the
previous buffer, but I don't think that's necessary - it does not seem
to be doing anything.
I'm hoping this will resolve the issue and not cause any (untested)
features to break, but I think it should be quite safe.
refactor(tests): fix missing argument warning
Did not cause any issues though