fix(openings): prefer PGN headers and improve transposition handling - #8
Merged
Conversation
- prioritize PGN Opening and ECO headers during enrichment - add side-aware transposition fallback for move-based detection - avoid returning shallow early matches when deeper matches are available test(openings): add coverage for header priority and QGD transpositions - add tests for PGN header-based opening detection - cover transposed lines (d4 e6 c4 d5 vs d4 d5 c4 e6) - extend parser and enrichment test cases docs(readme): document updated opening detection behavior - describe PGN header priority over move-based detection - explain fallback detection and transposition handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(openings): add coverage for header priority and QGD transpositions
docs(readme): document updated opening detection behavior