fix(pgn): normalize moves for more reliable opening detection - #7
Merged
Conversation
mik0lajek
commented
May 4, 2026
mik0lajek
commented
Owner
- strip semicolon comments and parenthesized variations from parsed move text
- add normalizeMovesForOpeningDetection utility for matching purposes
- use normalized moves in opening detection instead of raw tokens
- preserve original parsed moves (with annotations) for display
- add parser tests for variations, NAGs, move numbers, results, checks, mates, and annotations
- add end-to-end enrichment test to verify annotated PGN still matches openings
- strip semicolon comments and parenthesized variations from parsed move text - add normalizeMovesForOpeningDetection utility for matching purposes - use normalized moves in opening detection instead of raw tokens - preserve original parsed moves (with annotations) for display - add parser tests for variations, NAGs, move numbers, results, checks, mates, and annotations - add end-to-end enrichment test to verify annotated PGN still matches openings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.