Skip to content

[Closes #1917] Finish date is not populated when status changes to Completed#2727

Open
shrikantbadwaik wants to merge 4 commits intomihonapp:mainfrom
shrikantbadwaik:shrikant/bug/tracker-end-date
Open

[Closes #1917] Finish date is not populated when status changes to Completed#2727
shrikantbadwaik wants to merge 4 commits intomihonapp:mainfrom
shrikantbadwaik:shrikant/bug/tracker-end-date

Conversation

@shrikantbadwaik
Copy link

@shrikantbadwaik shrikantbadwaik commented Nov 20, 2025

Closes #1917: Finish date is not automatically populated for MAL and AniList trackers when status changes to Completed
Solution: Added logic to populate the finish date when the status is manually changed to "Completed".

Changelog:

  • Modified setRemoteStatus to update finished reading date along with last chapter read

Before:
Screenshot_2025-11-20-17-44-10-88_26a36124410e515f1c828a600e1d46de

After:
Screenshot_2025-11-20-17-42-23-39_26a36124410e515f1c828a600e1d46de

@Smol-Ame

This comment was marked as resolved.

@shrikantbadwaik shrikantbadwaik changed the title [BugFix] Finish date is not populated when status changes to Completed [BugFix Closes #1917] Finish date is not populated when status changes to Completed Nov 20, 2025
@shrikantbadwaik shrikantbadwaik changed the title [BugFix Closes #1917] Finish date is not populated when status changes to Completed [Closes #1917] Finish date is not populated when status changes to Completed Nov 20, 2025
@shrikantbadwaik shrikantbadwaik changed the title [Closes #1917] Finish date is not populated when status changes to Completed [Issue #1917] Finish date is not populated when status changes to Completed Nov 20, 2025
@shrikantbadwaik shrikantbadwaik changed the title [Issue #1917] Finish date is not populated when status changes to Completed [Closes #1917] Finish date is not populated when status changes to Completed Nov 20, 2025
@shrikantbadwaik
Copy link
Author

@Smol-Ame please help review my pr

@shrikantbadwaik
Copy link
Author

@Smol-Ame bumping this

@Smol-Ame
Copy link
Contributor

I am not a maintainer/developer of Mihon, wait patiently for your PR to be reviewed and/or approved.

@AntsyLich
Copy link
Member

add a changelog entry

@shrikantbadwaik
Copy link
Author

@AntsyLich added changelog

@AntsyLich
Copy link
Member

i see no changelog

@shrikantbadwaik
Copy link
Author

Please check again I have added it to description right before screenshots @AntsyLich

@Turhvjbufv
Copy link

Please check again I have added it to description right before screenshots @AntsyLich

Changelog should be added to this file
https://github.com/mihonapp/mihon/blob/main/CHANGELOG.md

You can look at other pr for examples

@shrikantbadwaik shrikantbadwaik force-pushed the shrikant/bug/tracker-end-date branch from e11f4bb to ed01eb3 Compare January 12, 2026 10:02
@shrikantbadwaik
Copy link
Author

Updated the Changelog

@AntsyLich AntsyLich enabled auto-merge (squash) January 17, 2026 10:55
auto-merge was automatically disabled February 25, 2026 06:07

Head branch was pushed to by a user without write access

@shrikantbadwaik
Copy link
Author

@AntsyLich @Turhvjbufv please help review

@Turhvjbufv
Copy link

Turhvjbufv commented Feb 25, 2026

@AntsyLich @Turhvjbufv please help review

I'm not a maintainer unfortunately, just helped you out before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish date is not automatically populated for MAL and AniList trackers when status changes to Completed

4 participants