Add disambiguator to chapter filenames to handle duplicate chapter names by raxod502 · Pull Request #2305 · mihonapp/mihon

raxod502 · 2025-07-24T17:32:22Z

This is #2206 in combination with fatotak#4 and fatotak#5. Please see the original PR description as well as #2206 (comment) and #2206 (comment) for further context; a brief summary of the changes follows:

Downloaded chapters use a filename with a truncated MD5 hash of the chapter URL, to prevent identically-named chapters from overwriting each other when downloaded.
Previously downloaded chapters, which do not include the hash, are still read by Mihon, but new chapters are saved with the new filename format.
Filenames of more than 240 bytes are disallowed; this was already the intention of the existing code, but due to a bug, longer filenames were sometimes allowed, leading to errors when those filenames were used to write to disk.
There is a new option in the advanced settings, which disallows non-English (non-ASCII) characters from being used in filenames. This should not be enabled except in cases where the user's storage medium is hopelessly broken and cannot be fixed to comply with international Unicode standards.
- When enabled, all existing filename restrictions are still applied, and on top of that, any non-ASCII characters are replaced with their hexadecimal representations. This applies to source names, manga names, and chapter names.
- Existing chapters downloaded before the user flips the setting (in either direction) can still be found by the app, unless the containing source or manga directory names contained non-ASCII characters as well. The latter exception is because we don't currently have a way for Mihon to check multiple possible source or manga directory names, but we do have a way for it to check multiple possible chapter filenames, which I used.
- This setting bans ALL non-English characters, making foreign-language titles unreadable. If this is undesirable to the user, they can provide more detailed and verifiable information about what characters do and don't work on their device, so that we can adjust the setting to be more fine-grained - however at present no user has provided this information so we can't implement anything better.

Resolves #1395.
Resolves #2280.
Resolves #1633.
Resolves #1517.

Downloaded chapter before this change:

./コミックグロウル (ALL)/王太子の婚約者はもう耐えられない！/BUSHIROAD WORKS_(前編).cbz

Downloaded chapter after this change:

./コミックグロウル (ALL)/王太子の婚約者はもう耐えられない！/BUSHIROAD WORKS_(前編)_214cd0.cbz

Downloaded chapter after this change, with the setting enabled to disallow non-English characters in filenames:

./e382b3e3839fe38383e382afe382b0e383ade382a6e383ab (ALL)/e78e8be5a4aae5ad90e381aee5a99ae7b484e88085e381afe38282e38186e88090e38188e38289e3828ce381aae38184efbc81/BUSHIROAD WORKS_(e5898de7b7a8)_214cd0.cbz

Please see also mihonapp/website#161, which adds documentation as was requested by @Foffs on Discord.

See also #2332, which improves the behavior of LocalSource with less readable filenames.

Fixed: new downloads. Working: reading. Todo: migrate old chapters to new name + delete and force redownload of problem chapters (chapters within a manga where name and scanlator are the same value).

…able, and equally unique.

…d is more appropriate for new file naming format.

…ent_chapters_with_same_name Improvements to PR#2206

data/src/main/sqldelight/tachiyomi/migrations/6.sqm

domain/src/main/java/tachiyomi/domain/download/model/ChapterDownload.kt

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadProvider.kt

AntsyLich · 2025-07-25T00:00:17Z

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadProvider.kt

@@ -165,24 +196,30 @@ class DownloadProvider(
    }

    fun isChapterDirNameChanged(oldChapter: Chapter, newChapter: Chapter): Boolean {


Now that I think about it this function doesn't really account for name schema change

Would you like me to make changes to it?

If possible. Feel free to make this it's own PR so we can ship it separately than this feature.

Was this accounted for?

You said it could be a separate PR, so changes to it aren't included here.

…_chapters_with_same_name

AntsyLich · 2025-07-30T22:44:03Z

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadProvider.kt

@@ -165,24 +196,30 @@ class DownloadProvider(
    }

    fun isChapterDirNameChanged(oldChapter: Chapter, newChapter: Chapter): Boolean {


If possible. Feel free to make this it's own PR so we can ship it separately than this feature.

source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt

This reverts commit e8214a4.

i18n/src/commonMain/moko-resources/base/strings.xml

…_chapters_with_same_name

MajorTanya

As I mentioned in the non-English vs non-ASCII comment, I strongly prefer going with non-ASCII but I refrained from making change suggestions everywhere. Seemed excessive to me to post like, 20 suggestions when it's effectively what, like 3 standard refactor -> rename operations in an editor/IDE.

Otherwise just a few things that stood out to me from reading the code. Excellent work.

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadProvider.kt

i18n/src/commonMain/moko-resources/base/strings.xml

core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/DiskUtil.kt

…ovider.kt Co-authored-by: MajorTanya <39014446+MajorTanya@users.noreply.github.com>

MajorTanya

My points are resolved, I have nothing else to say ~~currently~~

Not sure what the others think though.

…_chapters_with_same_name

raxod502 · 2025-08-06T23:15:37Z

Added changelog entry

i18n/src/commonMain/moko-resources/base/strings.xml

CHANGELOG.md

AntsyLich · 2025-10-05T10:59:45Z

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadProvider.kt

@@ -165,24 +196,30 @@ class DownloadProvider(
    }

    fun isChapterDirNameChanged(oldChapter: Chapter, newChapter: Chapter): Boolean {


Was this accounted for?

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>

…_chapters_with_same_name

CHANGELOG.md

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>

…ionally for OSes that don't support Unicode in filename (mihonapp/mihon#2305) Co-authored-by: jkim <jhskim@hotmail.com> Co-authored-by: fatotak <111342761+fatotak@users.noreply.github.com> Co-authored-by: MajorTanya <39014446+MajorTanya@users.noreply.github.com> Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit 58b25d697f7987e9888344e815d5646ec010a663)

…ionally for OSes that don't support Unicode in filename (mihonapp#2305) Co-authored-by: jkim <jhskim@hotmail.com> Co-authored-by: fatotak <111342761+fatotak@users.noreply.github.com> Co-authored-by: MajorTanya <39014446+MajorTanya@users.noreply.github.com> Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>

jhskim and others added 10 commits June 17, 2025 00:00

Partial implementation of fix for issue 1395.

ea420cb

Fixed: new downloads. Working: reading. Todo: migrate old chapters to new name + delete and force redownload of problem chapters (chapters within a manga where name and scanlator are the same value).

changed md5(chapter.url) to chapter.id, as chapter.id will be more st…

ba7f2ba

…able, and equally unique.

changed to 0 impact change while decision pending on whether url or i…

a1d35b2

…d is more appropriate for new file naming format.

Improvements to PR#2206

0af9f91

Merge pull request mihonapp#4 from radian-software/bugfix/1395_differ…

d7f4d3d

…ent_chapters_with_same_name Improvements to PR#2206

Reduce diff

e7c79f6

Cap filename length correctly

b4a55dc

Use XML metadata for local source

576d950

Switch to more memory-efficient implementation

4febec5

Remove buildValidFilenameLegacy

e2f0337

raxod502 mentioned this pull request Jul 24, 2025

Partial implementation of fix for issue 1395. #2206

Closed

Apply standard code formatting

0138de4

AntsyLich reviewed Jul 25, 2025

View reviewed changes

Suggestions from PR review

d5c1243

This was referenced Jul 25, 2025

Symbols <> in title name (and file name as result) prevent application from downloading. #1633

Closed

rename chapters before downloading #1517

Closed

raxod502 added 4 commits July 30, 2025 11:53

Merge remote-tracking branch 'origin/main' into bugfix/1395_different…

286b424

…_chapters_with_same_name

Add option for disallowing non-English filenames

cc6b256

Remove comment per code review

00d0e47

Trigger another CI run

8893f6a

raxod502 mentioned this pull request Jul 30, 2025

Add documentation on download filesystem layout mihonapp/website#161

Merged

raxod502 requested a review from AntsyLich July 30, 2025 21:35

AntsyLich requested changes Jul 30, 2025

View reviewed changes

raxod502 mentioned this pull request Jul 31, 2025

Use metadata for LocalSource #2332

Merged

raxod502 requested a review from AntsyLich July 31, 2025 18:46

Revert "Use metadata for LocalSource"

78d6fe3

This reverts commit e8214a4.

MajorTanya reviewed Aug 2, 2025

View reviewed changes

i18n/src/commonMain/moko-resources/base/strings.xml Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into bugfix/1395_different…

278db35

…_chapters_with_same_name

raxod502 requested a review from MajorTanya August 2, 2025 22:24

MajorTanya suggested changes Aug 3, 2025

View reviewed changes

raxod502 and others added 3 commits August 3, 2025 18:10

Update app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadPr…

eba5da6

…ovider.kt Co-authored-by: MajorTanya <39014446+MajorTanya@users.noreply.github.com>

fixed

3c749d7

say ASCII instead of English

8e17a52

raxod502 requested a review from MajorTanya August 4, 2025 01:24

MajorTanya approved these changes Aug 4, 2025

View reviewed changes

AntsyLich added this to the v0.20.0 milestone Aug 6, 2025

raxod502 added 2 commits August 6, 2025 16:11

Merge remote-tracking branch 'origin/main' into bugfix/1395_different…

738e888

…_chapters_with_same_name

Add changelog

50dac2a

Merge branch 'main' into bugfix/1395_different_chapters_with_same_name

a88b646

raxod502 mentioned this pull request Aug 8, 2025

Further improvements to PR#2206 fatotak/mihon#5

Closed

AntsyLich requested changes Oct 5, 2025

View reviewed changes

raxod502 and others added 3 commits October 5, 2025 09:07

Update i18n/src/commonMain/moko-resources/base/strings.xml

1df1926

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>

Fix bad merge

3b82782

Merge remote-tracking branch 'origin/main' into bugfix/1395_different…

fd327bb

…_chapters_with_same_name

raxod502 requested a review from AntsyLich October 5, 2025 16:36

AntsyLich approved these changes Oct 7, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

raxod502 and others added 3 commits October 7, 2025 15:28

Apply suggestions from code review

73634ac

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>

Fix

9bd2153

Fix also

be9b4f1

raxod502 requested a review from AntsyLich October 7, 2025 22:31

AntsyLich approved these changes Oct 7, 2025

View reviewed changes

AntsyLich merged commit 58b25d6 into mihonapp:main Oct 7, 2025
1 check passed

raxod502 deleted the bugfix/1395_different_chapters_with_same_name branch October 8, 2025 00:37

TheUnlocked mentioned this pull request Oct 11, 2025

Mangaplus: Add a true chapter number for downloads keiyoushi/extensions-source#5056

Open

5 tasks

Vandino86 mentioned this pull request Nov 11, 2025

[Feature Request] Add partial MD5 hash in downloaded chapter filenames (from Mihon v0.19.2) Suwayomi/Suwayomi-Server#1783

Open

4 tasks

AntsyLich removed this from the v0.20.0 milestone Dec 1, 2025

		@@ -165,24 +196,30 @@ class DownloadProvider(
		}

		fun isChapterDirNameChanged(oldChapter: Chapter, newChapter: Chapter): Boolean {

Uh oh!

Conversation

raxod502 commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AntsyLich Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

raxod502 Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

AntsyLich Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

AntsyLich Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

raxod502 Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

AntsyLich Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MajorTanya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MajorTanya left a comment

Choose a reason for hiding this comment

Uh oh!

raxod502 commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

AntsyLich Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

raxod502 commented Jul 24, 2025 •

edited

Loading