Introduce @after_completed_request decorator #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirko
force-pushed
the
add-after_completed_req-decorator
branch
from
e2b378d to
50d5245
Compare
|
(Initial) discussion: #289 |
src/microdot/microdot.py
Outdated
| for handler in self.get_request_handlers( | ||
| req, 'after_completed_request', True): | ||
| res = await invoke_handler( | ||
| handler) or res |
There was a problem hiding this comment.
What would be the point of res here? You aren't passing any arguments to this handler, and you aren't doing anything with the return value, so why have it?
There was a problem hiding this comment.
ack, copy & paste - guess i should have waited for after a good night's sleep and actually review and understand the lines i just copied from elsewhere.
In some situations code might want to be executed after the request was handled *and completed*. The completed part is what makes it different to the already existing @after_request decorator, which respectively decorated functions are executed after the request was handled, but still before the HTTP client's request was being responded to.
mirko
force-pushed
the
add-after_completed_req-decorator
branch
from
50d5245 to
3d3b644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations code might want to be executed after the request was handled and completed. The completed part is what makes it different to the already existing @after_request decorator, which respectively decorated functions are executed after the request was handled, but still before the HTTP client's request was being responded to.